Merge dependency bumps and add theme backgroundColor support#47
Merged
Merge dependency bumps and add theme backgroundColor support#47
Conversation
….1' of https://github.com/trycourier/courier-react-native into cursor/merge-prs-add-background-color-b765 Co-authored-by: Mike Miller <mike@mikemiller.design>
- Add backgroundColor property to CourierInboxTheme and CourierPreferencesTheme TypeScript interfaces - Pass backgroundColor to native Android CourierInboxTheme and CourierPreferencesTheme constructors - Apply backgroundColor on iOS views based on current user interface style (light/dark) - Update example app to demonstrate backgroundColor usage in styled inbox and preferences Co-authored-by: Mike Miller <mike@mikemiller.design>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges two dependency bump PRs and adds support for setting a background color in the inbox and preferences themes.
Merged PRs
New Feature: Theme Background Color
Adds a
backgroundColorproperty to bothCourierInboxThemeandCourierPreferencesTheme, allowing users to set a custom background color for these views through the theme system.TypeScript
Implementation Details
backgroundColordirectly to the nativeCourierInboxThemeandCourierPreferencesThemeconstructors (supported in courier-android 5.3.1)Changes
src/models/CourierInboxTheme.tsx— AddedbackgroundColor?: stringsrc/models/CourierPreferencesTheme.tsx— AddedbackgroundColor?: stringios/CourierInboxReactNativeManager.swift— Apply background color on the viewios/CourierPreferencesReactNativeManager.swift— Apply background color on the viewandroid/.../CourierInboxViewManager.kt— Pass backgroundColor to theme constructorandroid/.../CourierPreferencesViewManager.kt— Pass backgroundColor to theme constructorexample/— Updated styled examples to demonstrate backgroundColor usage